search

rzukic / zed-latex

33 stars 4 forks source link

feat: update to zed_extensions_api 0.1 #14

Closed jrg1k closed 2 months ago

jrg1k commented 2 months ago

Bymp versions. Also should Cargo.lock be checked into git? Other extensions don't do this as far as I can tell.

lnay commented 2 months ago

This will conflict with PR #10, I didn't update to 0.1 in that PR because it didn't seem to work with the stable Zed release at the time.

As for the lockfile, it's fairly normal with other package managers to version control the lockfile, the Rust book suggests that putting it under version control should be the default decision. But even outside of Zed extensions, it does seem that it's commonly not tracked (e.g. num crate).

lnay commented 2 months ago

This can be parked for now, v0.0.4 of this extension doesn't make use of any of the extra stuff provided in the newer zed_extensions_api. You can redo these changes on top of the current HEAD of main if you want, to then be merged for the next version.

nb. if you would like to appear as a contributor, you could commit with credentials matching your GitHub account.