Add module-info.java, fixes #2

zimmi commented 3 years ago

I also took the liberty to do the following things, please tell me if I should revert some of them:

Bump test dependency + plugin versions
Set project.build.sourceEncoding to fix build warning
Fix FileListTest when run as a module
Bump Travis JDK version to oraclejdk9 (I assume that's the reason the build fails there right now)
Set scm.url without property reference so it works on search.maven.org. You can see the current sad display here: https://search.maven.org/artifact/com.github.rzymek/opczip/1.2.0/jar

The --add-opens args for surefire are needed because JUnit reflectively calls the package private test methods, and that's not allowed when we are a module. An alternative would be to make every test class / method public, but that will probably just annoy future developers while providing little gain.

rzymek commented 3 years ago

Oh, damm! I haven't pushed my commit for Java 8 compatibility I've made a year ago :facepalm: Pushed them now.

zimmi commented 3 years ago

Haha, always good to be prepared! I'll take a look.

zimmi commented 3 years ago

@rzymek I rebased onto master and switched back to target Java 8. Please take another look.

Note: The project still has to be compiled with Java 9+ so the compiler understands the module-info. If building with Java 8 is needed, we could use https://github.com/moditect/moditect (generates module-info.class by ASM magic).

rzymek / opczip

Add module-info.java, fixes #2 #3