Open/Save dialog freeze on Lion

[GoogleCodeExporter]

Hello,

I'm been testing the latest beta os Mac OS Lion these days.

I noticed only one bug in MacVim : When I use the "Open" or "Save As" menu, Vim 
will freeze for some time, then display in the statusbar the command it used, 
but it will do nothing.

Also, from times to times, I get it to let me continue editing, but some of the 
editor commands will not work, if not every one of them. (It's really random). 
Usually even the "classic" :wq is broken.

I am using MacVim snapshot 57, and Mac OS X Lion 10.7 DP 2 (it also does that 
on DP1)

I am aware that you might not accept bug reports from OSX betas, because well, 
they are betas, but I don't think that Apple will change anything that is going 
to fix this, so it might be still bugged in the final release.

(And I really miss non-terminal vim)

If you need any help for testing, etc ... I'll be glad to test for you !

Original issue reported on code.google.com by dreamtea...@gmail.com on 2 Apr 2011 at 8:37

[GoogleCodeExporter]

Thanks for reporting the issue.  However, I cannot take any action on this 
until Lion is released and I have a copy myself.  Until then I have to rely on 
beta testers to send me patches.

I have no idea what may be causing this behavior.  You could generate a debug 
log [1] and send it to me...maybe I can guess from that what is going wrong, 
but probably not.

[1] https://github.com/b4winckler/macvim/wiki/Debugging

Original comment by bjorn.winckler@gmail.com on 2 Apr 2011 at 10:30

[GoogleCodeExporter]

I attached a partial log, the rest is only some mouse event stuff.

I'm not sure it does have useful information.

Being a dev too, I'll try to fix it whenever I have time ! But the issue is not 
a big deal, :w /path does still work.

Original comment by dreamtea...@gmail.com on 2 Apr 2011 at 10:39

Attachments:

• macvimpatial.log

[GoogleCodeExporter]

Well, I see an assertion being triggered inside the NSSavePanel code which I'm 
guessing is the cause of the problems.  I can't tell why this is happening but 
perhaps it is due to some API change related to NSSavePanel.

If you get some time, try looking at -[MMVimController handleBrowseForFile].  
Lines 1382-1395 are the interesting ones.  I would try commenting out lines 
1387-1389 to see if perhaps the "show hidden files" button is the cause of the 
problem (the delegate method panel:willExpand: is perhaps doing something 
unexpected).

Let me know how it goes.

Original comment by bjorn.winckler@gmail.com on 2 Apr 2011 at 10:58

[GoogleCodeExporter]

Tested it a little further, and commenting these lines doesn't do the trick. I 
will try more things later.

Original comment by dreamtea...@gmail.com on 5 Apr 2011 at 3:50

[GoogleCodeExporter]

So, with those lines commented out does the problem still happen with the "save 
panel"?  Or is it only with the "open panel"?  (If so, comment out line 1399 as 
well.)

If not, I'm not really sure what's going on.  If you can figure out what's 
causing the assert in NSSavePanel then you'll probably find the problem.

Original comment by bjorn.winckler@gmail.com on 5 Apr 2011 at 4:29

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

Sorry for the spam. I deleted the useless comments.

Both open and save panels are broken. Even if I comment out this "Show hidden 
files" code.

I also tried to reimplement the saving code using non deprecated code 
(beginSheetForDirectory is deprecated since 10.6), and it still doesn't work.

I also commented out the whole expand delegate thingy, still no luck.

I'm really starting to think that it's an internal apple bug, since the 
exception occurs in their private class method, which is not called by your 
code anywhere.

Original comment by dreamtea...@gmail.com on 5 Apr 2011 at 6:01

[GoogleCodeExporter]

OK, thanks for trying.  If you have any ideas or figure something out please 
let me know, otherwise I will just have to take a look at this once Lion is 
released.

Original comment by bjorn.winckler@gmail.com on 5 Apr 2011 at 6:12

[GoogleCodeExporter]

Confirming this is still an issue under the recent DP4.

Lion does change how Save and Open dialogues operate with the new application 
sandboxing features.  Could be an issue with that?

Original comment by nt.t...@gmail.com on 19 Jun 2011 at 5:41

[GoogleCodeExporter]

This bug has been fixed now, see

https://github.com/b4winckler/macvim/commit/8c1e9308543be77483f425f5f59a4883c9c4
6b60

I'd be grateful if I could get confirmation that this issue is fixed (which 
would required pulling the latest commit and building a custom MacVim).

I'll build a new snapshot when Lion is released.

Original comment by bjorn.winckler@gmail.com on 9 Jul 2011 at 5:59

• Changed state: Fixed

[GoogleCodeExporter]

You have my confirmation. It now works perfect on my Lion GM with the latest 
XCode beta.
Many many thanks to you, as MacVim is my main tool at work!

Original comment by cyrille....@gmail.com on 10 Jul 2011 at 11:00

[GoogleCodeExporter]

I am still having this issue - 2011-08-03 23:24:41.520 MacVim[7856:60b] *** 
Assertion failure in -[NSSavePanel _navView], 
/SourceCache/AppKit/AppKit-1138/Nav.subproj/NSSavePanel.m:489

Original comment by Dustin.W...@gmail.com on 4 Aug 2011 at 3:25

[GoogleCodeExporter]

You must still be running an old version of MacVim.  Download the latest 
snapshot [1] and delete all old versions of MacVim.app from your hard drive 
(Spotlight search for MacVim.app to find them).

[1] https://github.com/b4winckler/macvim/wiki/ChangeLog

Original comment by bjorn.winckler@gmail.com on 4 Aug 2011 at 8:43

[GoogleCodeExporter]

I'm seeing the same, it appears to be after I use cmd+alt+[direction] to switch 
panels directly after saving (and happens often enough that I've been losing a 
decent amount of work)

Original comment by lee.hamb...@gmail.com on 4 Aug 2011 at 8:27

[GoogleCodeExporter]

[MacVim 7.3 is currently the newest version available.] (in relation to my 
last.)

$ 2011-08-04 22:26:14.324 MacVim[6623:407] *\ Assertion failure in -[NSSavePanel _navView], /SourceCache/AppKit/AppKit-1138/Nav.subproj/NSSavePanel.m:489

Original comment by lee.hamb...@gmail.com on 4 Aug 2011 at 8:28

[GoogleCodeExporter]

Works for me using snapshot 61, didn't test snapshot 60 since it is not needed

Original comment by dreamtea...@gmail.com on 4 Aug 2011 at 11:00

[GoogleCodeExporter]

#16: Please just follow the link in #14 and manually download the latest 
snapshot.  It works.

Original comment by bjorn.winckler@gmail.com on 5 Aug 2011 at 11:51