Fix force parameter for ondemand, when using recent electron version

s-KaiNet / node-sp-auth

Unattended SharePoint http authentication with nodejs

MIT License

137 stars 56 forks source link

Fix force parameter for ondemand, when using recent electron version #91

Closed nmtoblum closed 3 years ago

nmtoblum commented 3 years ago

Hi Sergei,

I noticed that the force parameter for ondemand authentication isn't working if you're on a recent electron version. The browser window is opened, but no page/login screen is loaded. The reason is that the clearStorageData() function is asynchronous since quite some time now. See: https://www.electronjs.org/docs/api/session#sesclearstoragedataoptions

I was able to fix this really easy and just wanted to contribute my changes back to the project.

Best regards Tobias

s-KaiNet commented 3 years ago

Hi Tobias!

First of all, thank you very much for your contribution! Secondly, I'm really sorry that I have totally missed this PR. In autumn I was totally out of sync not only with GutHub, but with the whole world. Mostly due to different things which were happening in my country.

But better later than never! I merged your PR manually, so your contribution is available in the Git history. I'm closing this one. The lib was updated to 3.0.2.