search

s-KaiNet / spfx-fast-serve

Improve your SharePoint Framework development flow by speeding up the "serve" command :rocket:
MIT License
135 stars 11 forks source link

[spfx-fast-serve-helpers] MacOS & yarn: unable to run fast-serve due to CRLF line endings #92

Closed salascz closed 1 year ago

salascz commented 1 year ago

Hello, not sure if I am the first one, who is trying to use this tool with classic Yarn (1.x) on macOS environment - there seems to be an issue with CRLF line endings.

Output from 'serve' script (empty SPFx project with HelloWorld webpart): image

As a fix, I need to change the line breaks in /node_modules/.bin/fast-serve (its a link to your serve.js file) to LF only.

I am not the node.js expert, but it looks like well known issue that is partially solved by package managers (NPM should change the line endings automatically). Unfortunately, such a feature was not implemented in Yarn :-(.

Is it something that could be fixed for future versions?

(tested on empty spfx projects 1.15.2 & 1.16.1 with spfx-fast-server-helpers 1.15.4 and 1.16.1)

s-KaiNet commented 1 year ago

Hello, sorry for the late reply. I published updated versions of lib - 1.15.5 and 1.16.3 correspondingly. Just make sure that you have any of these versions in your dependency tree.

salascz commented 1 year ago

No worries, thanks for the update. Tested and works without issues. I appreciate you fixed both version.