s-celles / APC

APC power switch automation
MIT License
30 stars 9 forks source link

Fix issue #9: add second pattern-matching for outlet parsing #10

Closed CharlesB2 closed 5 years ago

CharlesB2 commented 5 years ago

It seems that APC versions can differ in their output, this PR handles two different forms of outlet printing

s-celles commented 5 years ago

Closes #9

s-celles commented 5 years ago

Thanks @CharlesB2 for this nice contribution.

s-celles commented 5 years ago

but I can't merge because CI is failing (I'm using protected master branch). Could you have a look?

s-celles commented 5 years ago

The problem seems to be about PEP8 See https://travis-ci.com/scls19fr/APC/builds/128819861#L304

CharlesB2 commented 5 years ago

Fixed it (Travis CI was actually already failing :) )

s-celles commented 5 years ago

Closes #11

Thanks @CharlesB2 for your contribution!