Fix inferior Lisp instance on Win10

s-clerc / slyblime

Interactive Lisp IDE with REPL, Inspector, Debugger and more for Sublime Text 4.

Other

45 stars 4 forks source link

Fix inferior Lisp instance on Win10 #12

Open MarbleKL opened 3 years ago

MarbleKL commented 3 years ago

Fix the path string. The connection will be refused if stdout & stderr are not set on Win10.

s-clerc commented 3 years ago

Hello,

Thank you for the contribution, unfortunately I have exams so I don't think I will be able to review this until at least 11th.

I don't have a Windows 10 machine, so I wasn't able to test it before, but I'm glad it's getting wider use now!

s-clerc commented 3 years ago

Hello,

Sorry for the delay, I was busy with things.

I was wondering if you could try using os.path.normpath instead of the replace operation, as I think that's more future-proof.

If you can make the change (or tell me it doesn't work), I can pull the PR.

Thanks!

la-ci commented 1 year ago

I have tried this patch manually on windows 10, the lines 173,174 are ok, but changing the line 179 from packages_path() to files_path() raised error reloading plugin Slyblime.sly name 'file_path' is not defined so if we skip that change, it works I'm running Sublime Text 4, Build 4143 os Windows 10, Version 22H2 (OS Build 19045.2965)

I believe people would appreciate using this little help on windows platform

s-clerc commented 1 year ago

Thanks guys for the help. I should comment that I’m currently in the exam season of my final year, so I won’t be able to look at any of this for a few weeks.