search

s-expressionists / Eclector

A portable Common Lisp reader that is highly customizable, can recover from errors and can return concrete syntax trees
https://s-expressionists.github.io/Eclector/
BSD 2-Clause "Simplified" License
108 stars 9 forks source link

Treat compiler warnings for unused variables #72

Closed kpoeck closed 3 years ago

kpoeck commented 3 years ago

Am trying to have the build process of clasp free of compiler warnings (to be able to see real problems). I know that in clasp we use a different branch, but wanted to start upstream.

The only changes are various (declare (ignore ..))so they should be safe.

For testing i build clasp with this branch, run the regression-tests and also the ansi-tests with no regressions.

scymtym commented 3 years ago

Thank you. I committed a slight variation of this in which I rearranged the order of arguments in some declarations and added similar declarations for methods defined in the test directory.

Regarding clasp: does it use the master branch or should I apply these changes to some other branch as well?

kpoeck commented 3 years ago

Clasp uses still uses with-signal since the signal implementation is so slow, at least on linux. If you could apply these changes also in with-signal , you'd help us greatly.

scymtym commented 3 years ago

I added the change (with minor adaption) to the without-signal branch.

kpoeck commented 3 years ago

ok, than I believe i can close this pr