search

s-fleck / lgrExtra

Extra Appenders for the lgr Package
https://s-fleck.github.io/lgrExtra/
Other
7 stars 2 forks source link

add AppenderAWSCloudWatchLog class #10

Open DyfanJones opened 11 months ago

DyfanJones commented 11 months ago

This enables lgr to append logs directly to AWS CloudWatch Logs.

Address Issue: https://github.com/s-fleck/lgrExtra/issues/9

DyfanJones commented 11 months ago

For the unit tests are you happy with mock tests?

I believe the overall cost from AWS would be minimal if any at all however with mock tests you don't need to worry about that 😄

s-fleck commented 11 months ago

I see this is still marked as draft... is this intentional and you are still working on it? if yes please ping me when it is ready for review :) (no hurry, i'm pretty bussy with other stuff anyways)

DyfanJones commented 11 months ago

@s-fleck I left it as draft due to the question around unit tests and using mock tests to help with costs. I will create the mock tests and ready it for review :)

DyfanJones commented 10 months ago

@s-fleck I have added some mock tests using the new mock framework in testthat so no extra dependencies are required. I have left the layout to be really simple with the timestamp removed (as AWS CloudWatch Logs tracks the time), however I am not tied to it and if you wish to add the timestamp back in feel free :)

After your review I believe we are ready to go 😄