search

s-hamann / desec-dns

A simple deSEC.io API client
MIT License
16 stars 5 forks source link

Added export-zonefile action #6

Closed patrickfl closed 1 year ago

patrickfl commented 1 year ago

Added export-zone file action which allows to directly download the domain export as zonefile.

patrickfl commented 1 year ago

Thank you for your contribution. It looks good at a first quick glance. I'd like to see a few minor changes before merging this.

A question though: What's your use case here? I did not try it yet, but the difference between export-zone and redirecting the output of get-records to a file seem minimal to me.

You are right the differences are only minimal, get-records is for example missing the SOA record. The idea behind this PR is to provide a 1:1 cli function for the desec REST API zone file endpoint (/domains/{domain}/zonefile/)