search

s-kybound / pe

0 stars 0 forks source link

No outgoing actor in sequence diagram #12

Open s-kybound opened 1 year ago

s-kybound commented 1 year ago

image.png

There is no outgoing actor specified in the sequence diagram describing duplicate detection. Hence it is unclear in which scenarios this sequence occurs.

nus-se-bot commented 1 year ago

Team's Response

The scenario in which the sequence occurs is stated clearly both in the implementation directly below the diagram and within diagram itself.

  1. Below the diagram (refer to highlighted text):

image.png

  1. Within the diagram, the duplicate company check is originating from the EditCommand class. Where the EditCommand has been invoked from is intentionally left out to avoid over-complicating the diagram and also because it is irrelevant to demonstrating the internals of the duplicate check within the Model component.

Since the term "outgoing actor" is not defined in this course #498, we will assume it to mean that there should be a return arrow pointing away from the EditCommand class. In which case, this arrow is not a must have for a sequence diagram, and has been intentionally left out as mentioned in point 2.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]