search

s-kybound / pe

0 stars 0 forks source link

Logger File is not recontextualised to LinkMeIn #3

Open s-kybound opened 9 months ago

s-kybound commented 9 months ago

image.png

The logger file saved by LinkMeIn has not been renamed for LinkMeIn, instead being named addressbook.log.0.

It would be good to remove all references to the original AB3 project.

soc-se-bot commented 9 months ago

Team's Response

We believe these this is a duplicate issue of 3200, which can also be fixed by the renaming of the logger.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Outdated Logger messages refer to AddressBook

On startup of the LinkMeIn application with java -jar LinkMeIn.jar (ignoring the special naming of the .jar file due to the PE), the Logger Messages generated by the application refer to the original AB3 template instead of the LinkMeIn application, namely in the [Initializing AddressBook] and the Creating a new ... populated with a sample AddressBook messages.

image.png

It would be good to recontextualize these logger messages for the application, to reduce confusion when reviewing Logger Messages.

[original: nus-cs2103-AY2324S1/pe-interim#4538] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We believe this is counted as Not In Scope as logger information is less important than the content of the GUI as mentioned by Prof below. The content of the GUI is accurate, which does not hinder the user/tester when using our app.

image.png

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: While similar, the issue of saving the logger file is separate from the issue of the displayed logger messages themselves.

Looking at the code, the saved name can be changed by changing the private field LOG_FILE in the file LogsCenter.java.

However, in resolving the logger messages themselves, they are changed in different areas, such as changing the various logger.info(...) calls in files such as MainApp.java.

As these issues stem from different root causes, and as such can be resolved separately, they are not duplicates.

## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]