s-kybound / pe

0 stars 0 forks source link

Error message on invalid date for deadline is not clear enough #4

Open s-kybound opened 9 months ago

s-kybound commented 9 months ago

image.png

On entering the incorrect date 29-02-2023, the error message prompts me to retry entering a valid deadline with the format DD-MM-YYYY.

This is beside the main issue, as the inputted date is of the correct formatting, but is itself invalid in nature.

Perhaps the error message could instead tell us that the deadline is invalid due to invalid values for the date.

nus-se-bot commented 9 months ago

Team's Response

We stated explicitly in the error message that the deadline is an invalid deadline which is true.

image.png

When the user enters a deadline of an incorrect format the following error message will be displayed instead.

image.png

the error message prompts me to retry entering a valid deadline with the format DD-MM-YYYY.

The purpose of stating this, is to remind the user of the correct deadline format to prevent them from typing an invalid deadline format when they re-enter the deadline.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: In the scenario of entering a validly formatted deadline with an invalid date, the contingency action suggested is to "try again with the deadline format DD-MM-YYYY."

Despite the fact that "an invalid deadline" was entered, due to the confusion caused by the incorrect contingency action, users may be confused, thinking that their deadline was invalid due to wrong formatting, and not invalid due to a wrong date. As such, I would still recommend that the error message be changed to mention "invalid date", which is more explicit than "invalid deadline", and show the correct contingency action, which is to enter a "valid date".