s-leger / archipack

Archipack for blender 2.79
https://blender-archipack.org
GNU General Public License v3.0
360 stars 50 forks source link

Archipack Error with Filmic addon #137

Open SimonMiller3D opened 5 years ago

SimonMiller3D commented 5 years ago

Archipack version:1.2.83

Blender version:2.8

Os version:windows 7

Description of the issue: Can only create walls. Any other object gives attached message.

Archipack error message

s-leger commented 5 years ago

Looks like your blender version is outdated ? You should download release from blender.org

SimonMiller3D commented 5 years ago

Hi.

Thank you for quick response.

I have uninstalled previous installation and downloaded latest Blender 2.8 from Blender.org, but the problem is still the same.

I can create a wall object fine but all other items bring up the error message.

From: s-leger notifications@github.com Sent: 10 August 2019 10:56 To: s-leger/archipack archipack@noreply.github.com Cc: SimonMiller3D simonmiller3d@gmail.com; Author author@noreply.github.com Subject: Re: [s-leger/archipack] Archipack Error (#137)

Looks like your blender version is outdated ? You should download release from blender.org

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/s-leger/archipack/issues/137?email_source=notifications&email_token=AKPKXLGLHKJQQOHFBSKEMLDQD2GCXA5CNFSM4IKZCU4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4AKJQA#issuecomment-520135872 , or mute the thread https://github.com/notifications/unsubscribe-auth/AKPKXLGHBHT6VOAEOC4ID7LQD2GCXANCNFSM4IKZCU4A . https://github.com/notifications/beacon/AKPKXLDKALQ4LBHDK725N33QD2GCXA5CNFSM4IKZCU4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4AKJQA.gif

s-leger commented 5 years ago

Something went wrong in your update process, Blender 2.8 release and current nighty build enumerator for color_space value are : ["Filmic Log", "Linear", "Linear ACES", "Non-Color", "Raw", "sRGB", "XYZ"]

Try to enter bpy.app.version into the blender's console in Scripting workspace should return (2, 80, 75) for 2.8 Release and (2, 81, 1) for last buildbot

You may try to get enum values (assuming there is at least one image in your file) using this into the blender's console in Scripting workspace. bpy.data.images[0].colorspace_settings.bl_rna.properties['name'].enum_items[:] return this on version >= (2, 80, 75) [<bpy_struct, EnumPropertyItem("Filmic Log")>, <bpy_struct, EnumPropertyItem("Linear")>, <bpy_struct, EnumPropertyItem("Linear ACES")>, <bpy_struct, EnumPropertyItem("Non-Color")>, <bpy_struct, EnumPropertyItem("Raw")>, <bpy_struct, EnumPropertyItem("sRGB")>, <bpy_struct, EnumPropertyItem("XYZ")>]

SimonMiller3D commented 5 years ago

Hi.

Sorry for the delay in responding.

Version 2.8 displays this in console

PYTHON INTERACTIVE CONSOLE 3.7.0 (default, Aug 26 2018, 16:05:01) [MSC v.1900 64 bit (AMD64)]

Command History: Up/Down Arrow

Cursor: Left/Right Home/End

Remove: Backspace/Delete

Execute: Enter

Autocomplete: Ctrl-Space

Zoom: Ctrl +/-, Ctrl-Wheel

Builtin Modules: bpy, bpy.data, bpy.ops, bpy.props, bpy.types, bpy.context, bpy.utils, bgl, blf, mathutils

Convenience Imports: from mathutils import ; from math import

Convenience Variables: C = bpy.context, D = bpy.data

bpy.app.version

(2, 80, 75)

bpy.data.images[0].colorspace_settings.bl_rna.properties['name'].enum_items[:]

[<bpy_struct, EnumPropertyItem("BT.1886 EOTF")>, <bpy_struct, EnumPropertyItem("Filmic Log Encoding")>, <bpy_struct, EnumPropertyItem("Linear")>, <bpy_struct, EnumPropertyItem("Non-Colour Data")>, <bpy_struct, EnumPropertyItem("sRGB EOTF")>]

I downloaded and installed buildbot 2.81 and Archipack works fine. Version 2.81 seems buggy though so would rather use 2.8.

Thankyou

From: s-leger notifications@github.com Sent: 11 August 2019 12:47 To: s-leger/archipack archipack@noreply.github.com Cc: SimonMiller3D simonmiller3d@gmail.com; Author author@noreply.github.com Subject: Re: [s-leger/archipack] Archipack Error (#137)

Something went wrong in your update process, Blender 2.8 release and current nighty build enumerator for color_space value are : ["Filmic Log", "Linear", "Linear ACES", "Non-Color", "Raw", "sRGB", "XYZ"]

Try to enter bpy.app.version into the blender's console in Scripting workspace should return (2, 80, 75) for 2.8 Release and (2, 81, 1) for last buildbot

You may try to get enum values (assuming there is at least one image in your file) using this into the blender's console in Scripting workspace. bpy.data.images[0].colorspace_settings.bl_rna.properties['name'].enum_items[:] return this on version >= (2, 80, 75) [<bpy_struct, EnumPropertyItem("Filmic Log")>, <bpy_struct, EnumPropertyItem("Linear")>, <bpy_struct, EnumPropertyItem("Linear ACES")>, <bpy_struct, EnumPropertyItem("Non-Color")>, <bpy_struct, EnumPropertyItem("Raw")>, <bpy_struct, EnumPropertyItem("sRGB")>, <bpy_struct, EnumPropertyItem("XYZ")>]

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/s-leger/archipack/issues/137?email_source=notifications&email_token=AKPKXLCAWHAQ5BIZX7TPAQ3QD733TA5CNFSM4IKZCU4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4A7IDQ#issuecomment-520221710 , or mute the thread https://github.com/notifications/unsubscribe-auth/AKPKXLDOWIY7ONM4KKCMDBLQD733TANCNFSM4IKZCU4A . https://github.com/notifications/beacon/AKPKXLGZUJ3WIBIHI5TYPNLQD733TA5CNFSM4IKZCU4KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD4A7IDQ.gif

s-leger commented 5 years ago

Ok, We are unable to repro this issue under win 7 and win 10. Could be an old factory startup, try to reload factory startup (File -> defaults -> load factory startup)

Sialek commented 5 years ago

@SimonMiller3D, I'm no sure if this will be the case for you, but I was encountering a very similar error because I had the Filmic Blender addon installed, which removed the "Raw" color space and replaced it with "Linear Raw", which Archipack isn't expecting it seems. My list of color spaces wasn't exactly the same as yours, but you may have an older version installed using the path variable method, so maybe it's getting picked up by that even in your fresh install.

I got both archipack and Filmic Blender working together by adding the raw color space and copied directly from the original ..\Blender\2.80\datafiles\colormanagement\config.ocio over into the colorspaces section of the filmic blender config.ocio file, as well as adding the line:

I'm fairly new to Blender, so take my advice with a grain of salt. This probably isn't the technically correct way to fix this, and I know it's not going to be convenient when Filmic Blender updates. Plus who knows what else it might mess with, so use at your own risk! And good luck solving your issue!

s-leger commented 5 years ago

Hi pretty interresting, thank you for sharing. May add Linear Raw and a fallback to sRgb so it wont fail anymore even with custom Filmic.

Sialek commented 5 years ago

No problem, the more compatibility the better! Also, a small addon to my previous post, I'm not sure whether it's targeting the "displays" or the "colorspaces" configs. if it's displays then it would be "Linear Raw", and if it's color spaces it would be just "Linear".

s-leger commented 5 years ago

Could you try to get enum values available with non standard Filmic (assuming there is at least one image in your file) using this into the blender's console in Scripting workspace, and report here ?

bpy.data.images[0].colorspace_settings.bl_rna.properties['name'].enum_items[:]

return this on version >= (2, 80, 75) [<bpy_struct, EnumPropertyItem("Filmic Log")>, <bpy_struct, EnumPropertyItem("Linear")>, <bpy_struct, EnumPropertyItem("Linear ACES")>, <bpy_struct, EnumPropertyItem("Non-Color")>, <bpy_struct, EnumPropertyItem("Raw")>, <bpy_struct, EnumPropertyItem("sRGB")>, <bpy_struct, EnumPropertyItem("XYZ")>]

Sialek commented 5 years ago

These are the results of running that command on 2.80 (sub 75):

[<bpy_struct, EnumPropertyItem("AppleP3 Filmic Log Encoding")>, <bpy_struct, EnumPropertyItem("AppleP3 sRGB OETF")>, <bpy_struct, EnumPropertyItem("BT.1886 EOTF")>, <bpy_struct, EnumPropertyItem("BT.1886 Filmic Log Encoding")>, <bpy_struct, EnumPropertyItem("Filmic Log Encoding")>, <bpy_struct, EnumPropertyItem("Linear")>, <bpy_struct, EnumPropertyItem("Non-Colour Data")>, <bpy_struct, EnumPropertyItem("Raw")>, <bpy_struct, EnumPropertyItem("sRGB OETF")>]

However, there are a few notes:

  1. I don't think I have a non-standard version of Filmic (unless you're talking the addon by the same name vs the default blender filmic setting). The original poster may, but I installed mine from the main instructions on their website only ~1-2 weeks ago, using the method where I rename the existing colormanagement folder and replace it. This is the file I modified: filmic-blender/config-ocio
  2. The output above would include my changes that I included in my early post adding the raw displays and the raw colorspace, so prior to my changes I think the EnumPropertyItem("Raw") would have been missing, where Filmic's intended alternative from that list is "Linear"
  3. I've not thoroughly tested the fix I tried. It does let me bring in archipack models now, but I haven't done any detailed renders with them.

Hope that answers your question. Sorry it's a bit muddied by my modifications.

s-leger commented 5 years ago

Should probably fallback to "Non-Colour Data" (should have same effect than Raw). By default blender color manage the thumbs, so both Raw and Non color prevent this behaviour an ensure the icons display is consistent whatever the color mode.

Sialek commented 5 years ago

That would probably work, just be careful of the "color" vs "colour", Blender seems to be US English and this addon (or perhaps my locale settings, Canadian here) seem to be from Canada, Europe, or somewhere else that likes the long spellings.

s-leger commented 5 years ago

Fixed, will be in 2.2.1 release