search

s-leroux / asciidoctor.js-pug

Allow to override the html5 output of asciidoctor.js with pug templates
3 stars 2 forks source link

Use a strict version of Asciidoctor.js #11

Closed ggrossetie closed 6 years ago

ggrossetie commented 6 years ago

Remove the direct dependency on Opal runtime. This dependency will be provided by Asciidoctor.js.

ggrossetie commented 6 years ago

Remove the direct dependency on Opal runtime. This dependency will be provided by Asciidoctor.js.

Since Opal runtime is explicitly required in the test, I had to reintroduce the opal-runtime dependency.

https://github.com/s-leroux/asciidoctor.js-pug/blob/3803ff8d42a4898be7f39beb4358557b4b9c8b67/test/opal-utils.js#L2

I think the main issue was that Opal was required twice (once in Asciidoctor.js with version 1.0.2 and once in the test with version 1.0.3). Now that we use the same version Node.js will only require the library once.

ggrossetie commented 6 years ago

@s-leroux Did you have a chance to review this pull request ?