search

s-leroux / fin

Set of tools for personal investment
MIT License
1 stars 0 forks source link

Distinguish between `from_sequence` and `import` #29

Closed s-leroux closed 3 months ago

s-leroux commented 3 months ago

https://github.com/s-leroux/fin/blob/16ec6073385b4f8bfeade58370ada605d59281f3/fin/seq/column.pyx#L384-L392

The Column.from_sequence method seems to have different purposes depending on the value of the convert parameter. We may distinguish between from_sequence, which creates a column from Python objects, and import, which creates a sequence from the textual representation of values.

s-leroux commented 3 months ago

Fixed in f18cf000e7c9b098473d10ac9c869920714228c2 while working on #27.