s-macke / SAM

Software Automatic Mouth - Tiny Speech Synthesizer
1.21k stars 267 forks source link

Fixed security vulnerability for arbitrary code execution #2

Closed b4sic4lly closed 9 years ago

b4sic4lly commented 9 years ago

Hello,

I found that your cool program uses "strcat" for processing command line arguments. This can be abused to execute arbitrary code. I created a fork and changed the function to "strncat" including the buffer length to fix this issue.

sincerely mft1

s-macke commented 9 years ago

Thanks mft1. There might be other problems in the code as well.