search

s-macke / jor1k

Online OR1K Emulator running Linux
http://jor1k.com
BSD 2-Clause "Simplified" License
1.73k stars 193 forks source link

Allow to set custom atime and mtime #133

Open invernizzi opened 6 years ago

invernizzi commented 6 years ago

SETATTR system calls that set a custom atime on an inode (e.g., touch -t 0102030405 a.txt) set both the SETATTR_ATIME and SETATTR_ATIME_SET flags. Prior to the fix, SETATTR_ATIME_SET was processed first, setting the custom atime correctly. Then, SETATTR_ATIME was processed, which updated the atime to the current time.

This execution order was essentially overwriting the custom atime immediately. The fix executes the two instructions in the correct order, and fixes a typo (an atime that should have been an mtime).

Before the fix:

root@host ~ >> touch -t 0102030405 a.txt                                    
root@host ~ >> stat a.txt                                                   
  File: a.txt                                                                   
  Size: 0               Blocks: 1          IO Block: 8192   regular empty file  
Device: 14h/20d Inode: 45939       Links: 1                                     
Access: (0644/-rw-r--r--)  Uid: (    0/    root)   Gid: (    0/    root)        
Access: 2018-02-02 23:13:29.000000000 +0000                                     
Modify: 2018-02-02 23:13:29.000000000 +0000                                     
Change: 2018-02-02 23:13:29.000000000 +0000                                     
 Birth: -

After the fix:

root@host ~ >> touch -t 0102030405 a.txt                                    
root@host ~ >> stat a.txt                                                   
  File: a.txt                                                                   
  Size: 0               Blocks: 1          IO Block: 8192   regular empty file  
Device: 14h/20d Inode: 45939       Links: 1                                     
Access: (0644/-rw-r--r--)  Uid: (    0/    root)   Gid: (    0/    root)        
Access: 2001-02-03 04:05:00.000000000 +0000                                     
Modify: 2001-02-03 04:05:00.000000000 +0000                                     
Change: 2001-02-03 04:05:00.000000000 +0000                                     
 Birth: -

(Thanks for an awesome project!)