search

s-nakaoka / choreonoid

An integrated graphical robotics application framework
http://choreonoid.org
Other
94 stars 58 forks source link

Remove double file ending #232

Closed AlgoryxJosef closed 4 years ago

AlgoryxJosef commented 4 years ago

This change will solve an issue where the assimp dll file get a double file ending (i.e. assimp-vc141-mt.dll.dll) when building with MSVC.

The variable ${library} already includes the .dll file ending.

s-nakaoka commented 4 years ago

Thank you for fix this problem.

s-nakaoka commented 4 years ago

I found that the problem you pointed only happens with Assimp version 5.0.x, and your modification causes a build error when using Assimp 4.0.x. That is because the specifications of the information provided by the CMake files are different between older and newer versions of Assimp. I have fixed CMakeLists.txt to support the both versions. https://github.com/s-nakaoka/choreonoid/commit/18500c3db69057a93c63e6435a83e370ee4444fc