search

s-peiran / pe

0 stars 0 forks source link

Fail to handle duplicate in person names #3

Open s-peiran opened 9 months ago

s-peiran commented 9 months ago

@CS2103T-T12-2

Screenshot from App: image.png

image.png

James Ho and james ho are likely to be the same person. Similarly, extra white space is unlikely to mean they are two different persons .Typically, it is best if you can give a warning in such near match cases so that the user can make the final decision.

If you app has a duplicate detection feature, make sure its limitations are made clear to the user so that users are not led to believe that duplicates are being detected while many potential duplicate cases go undetected. Otherwise, it can be considered a type.FeatureFlaw.

To duplicate, add contacts/persons with name 'James Ho', 'james ho' and 'James Ho' respectively.

soc-pe-bot commented 9 months ago

Team's Response

This is very clearly stated in the user guide that exact names are not allowed. Moreover, names are not case-sensitive as well. This is designed to give users flexibility in naming their contacts and we do not want to dictate that feature for them.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I refer to the PE Admin 'Guidelines for the dev team to follow when triaging PE bugs section'.

image.png

This is designed to give users flexibility in naming their contacts and we do not want to dictate that feature for them Whether having near duplicates serve any purpose would depend on whether the developers can come up with a use case for it. For which there isn't any use case in the UG, DG and their responses above.

Intuitively, users cannot be expected to remember every person(contact) he added, moreover the exact upper/lower case of the name, and whether there is an extra space. If the user attempts to add a close match, the app should warn the user that there is a close match so the user can make his own call whether he wants to proceed. If not, close duplicates would exist in the app and will cause problems later on when the user is trying to add the person to an event. For example, James Ho is supposed to be in both event 'Project Discussion' and event 'Group Lunch'. Because of the existence of duplicates, James Ho will be added to 'Project Discussion' and james ho will be added to 'Group Lunch'. This is a rather serious issue and would cause some users to experience occasional inconvenience.

Regarding the Issue of duplicate handing, the developers would gain immunity if they had added the issue to future/planned enhancements of the DG, which in this case they failed to do so.