search

s-r-x / bull-monitor

🐂 Standard UI for Bull and BullMQ.
https://s-r-x.github.io/bull-monitor/
MIT License
123 stars 38 forks source link

Support for bullmq ? #35

Closed mannharleen closed 2 years ago

mannharleen commented 2 years ago

Is there a plan to support bullmq?

s-r-x commented 2 years ago

@mannharleen hello. unfortunately, i don't use bullmq in production, so this one is not my highest priority atm. PRs are welcome, though!

mannharleen commented 2 years ago

do you reckon that the changes would mostly involve creating another class for BullMQ and implementing all that is here - https://github.com/s-r-x/bull-monitor/blob/main/packages/root/src/gql/data-sources/bull/index.ts

s-r-x commented 2 years ago

@mannharleen, don't think so. the main problem is that there is no abstraction over Queue class, and it is used as it is all over the place. For example, there is the text search class, that heavily relies on bull internals. One way to solve it is to wrap user defined queues in some kind of adapter. Otherwise if bull and bullmq apis are quite similar i guess you can patch the differences here and there using instanceof. Anyways bullqueue type should be changed everywhere from bullqueue to somequeueadapter in the first case, and to bullqueue | bullmqqueue in the second one. Which is helluva refactor

mannharleen commented 2 years ago

Understand. That sounds like a lot of rework 🤔

ccollie commented 2 years ago

@mannharleen what specifically are you looking for ? I imagine you've looked at bull-board which supports bullmq. Is there something missing in bull-board as well ?

s-r-x commented 2 years ago

added in 3.0.0

mannharleen commented 2 years ago

Thanks mate