Closed fritx closed 2 years ago
And it is better to replace Record<string, any>
with a JSONValue
implementation?
https://github.com/microsoft/TypeScript/issues/1897 https://dev.to/ankittanna/how-to-create-a-type-for-complex-json-object-in-typescript-d81
type JSONValue =
| string
| number
| boolean
| { [x: string]: JSONValue }
| Array<JSONValue>;
i don't understand how this is suppose to work, when there is no changes inside this getter
I'm using the bull-monitor cli, where bull-adapter
is used.
I can only see bullmq-adapter
is referenced in fixtures/bull-server/server
.
take a look at the readme. bull (or bullmq) adapter is required in order to make bull-monitor work, since we support both bull and bullmq.
btw now i understand why you are getting that weird gql error - our cli works fine only with bull(not bullmq)
yes, I'm using the cli, can we support it? maybe some option is needed?
definitely possible, i guess we can add some flag like "bullmq" to the cli and wrap queues with the appropriate adapter
Fix #14, below is the source code of bullmq:
https://github.com/taskforcesh/bullmq/blob/cf0710cfe322eb2147f439364b425763b4d5c592/src/classes/job.ts#L246
https://github.com/taskforcesh/bullmq/blob/cf0710cfe322eb2147f439364b425763b4d5c592/src/classes/scripts.ts#L231
I'm not sure is it ok to just change 'progress' from
Int
toJSON
, but it works for me in both cases: