codepathreview
commented
8 years ago :+1: Nice work. A few notes after checking out the code:
- Architecting the fragments (base class and extension classes) should be done such that you put as much code and logic as possible in the base class and then used abstract methods to define only the specific behavior where they differ. You have done a decent job but still there is some duplication
- Good to see you properly communicated the user to the user timeline fragment from the profile activity.
- Nice to see you used the ViewPager to properly setup the tabs!
- Good to see you played with styling
- Consider adding progress bars to your app whenever a network request goes out
- Try to implement more optional features so that you will get to play with more widgets and understand complexities involved
Here's a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.
This week (Week 5), we are going to cover the last major piece to the Android puzzle and that is using the hardware and SDK components such as the camera, photo gallery, location, maps, etc. After that, Week 6 and week 7 we will be covering a few important intermediate topics such as more about styling and animation as well as testing.
Following the bootcamp, we are going to have a public demo day to celebrate the progress you've all made with our next batch of Android students and multiple companies attending to see the group projects that you all have built. We are going to help however we can over the next few weeks to get the team project apps in shape for that.
My app is complete, please review. /cc @codepathreview @codepath
Please note that the paginating was working less than 3 hours ago, and something happened with the twitter api at the time of submission. The logic has been unchanged since last assignment and the issue is presumably on twitter's side at the moment.