Errors in loading key and certificate files fail silently

s-u / Rserve

Fast, flexible and powerful server providing access to R from many languages and systems

http://RForge.net/Rserve

Other

282 stars 65 forks source link

Errors in loading key and certificate files fail silently #160

Closed ericedelman-gh closed 3 years ago

ericedelman-gh commented 4 years ago

When the key and certificate files specified in Rserv.conf fail to load, this does not produce any messages, only resulting in a TLS handshake failure when later trying to connect to the server.

s-u commented 4 years ago

The proxy now handles that since b3dcabf and 7eb30c2 so likely we should do the same for Rserve that is used without the proxy.

ericedelman-gh commented 4 years ago

Those changes to the proxy look perfect, it would be great to have the same functionality for the main Rserve. Thanks so much.

s-u commented 3 years ago

This should now be addressed by efff0e3 For compatibility is just a warning. Part of the issue is that TLS initialization is de-centralized in Rserve, so the validity is not actually checked until a connection is initiated.