search

s-yadav / angulargrid

Pinterest like responsive masonry grid system for angular
MIT License
277 stars 105 forks source link

Math.min.apply(Math, lastRowBottom) returns NaN result in incorrect height #34

Open escapar opened 8 years ago

escapar commented 8 years ago

Not sure if it's my problem or not , just take a look in these pics 12 13

escapar commented 8 years ago

21 caused by this issue

number of listelem suddenly increased after a quick scroll

screen shot 2016-02-12 at 13 35 45
s-yadav commented 8 years ago

I will look into this. Is height coming NaN on scroll, or during initial load. ?

escapar commented 8 years ago

Only on scroll , initial height is OKAY.

s-yadav commented 8 years ago

version 0.5.2 must solve this. Check the new commit and let me know if you still face the same issue.

escapar commented 8 years ago

I've tried version 0.5.2 , for me the height calculation is still not working as expected :) I'm using infinite scroll , for some reason once I scroll (whatever how tightly I scroll) , many elements are loaded . I'll inspect deeply in this week .

escapar commented 8 years ago

It's fixed ! Appreciated. My problem comes from SPA element scroll listening and no fixed height for the container.