Potential infinite loop in getColWidth function

s-yadav / angulargrid

Pinterest like responsive masonry grid system for angular

MIT License

277 stars 105 forks source link

Potential infinite loop in getColWidth function #88

Closed nkovacic closed 8 years ago

nkovacic commented 8 years ago

If width on line 336 is for any reason 0, which happens if the directive is destroyed before it calculates width but the elements are still present (eg. when ui-router changes state), then an infinite loop occurs because no in line 340 becomes infinite and then line 408 crashes the application. This bug only happens when cssGrid option is true.

nkovacic commented 8 years ago

Made a pull request

s-yadav commented 8 years ago

Merged

nkovacic commented 8 years ago

A quick publish to npm for the latest fixes? :)

s-yadav commented 8 years ago

@nkovacic Done.