search

s-yadav / patternLock

A light weight plugin to simulate android like pattern lock interface for your hybrid app or website.
MIT License
378 stars 141 forks source link

version without jquery #8

Closed pochy-ja closed 6 years ago

pochy-ja commented 8 years ago

it would be possible to have a version without jquery?

In mobile systems like firefox OS, Jquery is to much for compatibility in the platform and the GAIA layer, because we need a version without jquery if would be possible.

s-yadav commented 8 years ago

What about zepto? Can you guys use zepto? It is light weight and patternlock must work on that too. Not tested though.

pochy-ja commented 8 years ago

Thanks, I submit a PR for you to do support in your library to use zepto o jquery, depend of the choice.

JosefJezek commented 8 years ago

http://youmightnotneedjquery.com

jasondavis commented 7 years ago

I was searching for a Native JS (non jQuery version) of a Pattern lock library and came across this library.

Looking at the code, it does not look like this library even uses jQuery for very many things.

At a quick glance I saw jQuery used to:

as mentioned I only glanced over the code quickly but from the look of it it seems those are the only items jQuery is needed for. All of these are very easy to switch out with Native JavaScript versions.

I might spend like 30 minutes and see if I can port it over to Native JS and if it works out i'll send a pull request for an optional 2nd pure JS version of the library. I have seen many other repos that offer a jQuery and Pure JS version of a library.

s-yadav commented 6 years ago

Finally after a long time removed jQuery dependency on v2.0.0

simowaer commented 6 years ago

@s-yadav jQuery is still listed as a dependency in package.json. How can we install this without jQuery?

s-yadav commented 6 years ago

Or must have missed it. Will fix this