Uncaught TypeError: Cannot read property 'children' of null

s-yadav / react-meta-tags

Handle document meta/head tags in isomorphic react with ease.

MIT License

226 stars 47 forks source link

Uncaught TypeError: Cannot read property 'children' of null #25

Closed Jbonez87 closed 5 years ago

Jbonez87 commented 5 years ago

The issue is in line 104 in meta_tags.js. There is no error handling if childStr is an empty string. I can make a pull request to fix this over the weekend if you'd like.

s-yadav commented 5 years ago

Sure PR is appreciated.

Jbonez87 commented 5 years ago

I've made my pull request. Please review

s-yadav commented 5 years ago

Released this. v0.7.3

AakashGfude commented 5 years ago

For line 109 in lib/meta_tags.js :-
var childNodes = Array.prototype.slice.call(_this.temporaryElement.querySelector('.react-head-temp').children);

I am getting Cannot read property 'children' of null. This line also needs to be handled ?