add null check for children and extract

s-yadav / react-meta-tags

Handle document meta/head tags in isomorphic react with ease.

MIT License

226 stars 47 forks source link

add null check for children and extract #26

Closed Jbonez87 closed 5 years ago

Jbonez87 commented 5 years ago

This will account for situations where asynchronous loading prevents document children elements from rendering right away. For example, if you are passing data from an api response as the initial state of a redux store and rendering components based on that store.

Jbonez87 commented 5 years ago

Ok I've updated my code. Please let me know if you need any additional changes

Jbonez87 commented 5 years ago

@s-yadav please review my changes.

s-yadav commented 5 years ago

Looks good. Merged it. Will test and release it