search

s-yadav / react-number-format

React component to format numbers in an input or as a text.
MIT License
3.88k stars 409 forks source link

Replace documentation examples #762

Closed adamriaz closed 1 year ago

adamriaz commented 1 year ago

Describe the issue/change

The docs are showing examples using CodeSandbox snippets rather than interacting the form fields directly.

Describe the changes proposed/implemented in this PR

Replacing the CodeSandbox example snippets on the docs with implemented jsx elements for users to try out the examples directly instead of loading them through iframes.

Example usage (If applicable)

https://adamriaz.github.io/react-number-format/docs/intro

Link Github issue if this PR solved an existing issue

460

Please check which browsers were used for testing

s-yadav commented 1 year ago

Appreciate the PR. But having code sandbox embed here was intentional so that people can play around with examples, or if any bug can fork from existing example and showcase the problem.

adamriaz commented 1 year ago

@s-yadav Okay so would you like to keep code sandbox for the examples? If that's the case, then I'll just close this PR.

s-yadav commented 1 year ago

Yes, would prefer having codesandbox embeds here.