search

s-yadav / react-number-format

React component to format numbers in an input or as a text.
MIT License
3.9k stars 410 forks source link

Difference between NumericFormat component and numericFormatter function #806

Open thiengo105 opened 1 year ago

thiengo105 commented 1 year ago

Describe the issue and the actual behavior

numericFormatter function should return the same value as NumberFormat component with the same props. image

Describe the expected behavior

numericFormatter should return 3.91 instead of 3.90

Provide a CodeSandbox link illustrating the issue

https://codesandbox.io/p/sandbox/react-number-format-gnsqpq

Provide steps to reproduce this issue

use the following props to pass to numericFormatter function and NumerFormat component:

value = 3.9082;
decimalScale = 2;

Please check the browsers where the issue is seen

portare commented 6 months ago

Also numericFormatter doesnt apply mapToRadix property

RifatF commented 5 months ago

Same problem with version 5.4.0. The parameter valueIsNumericString doesn't change anything.

AI111 commented 5 months ago

Here is the reason https://github.com/s-yadav/react-number-format/blob/master/src/numeric_format.tsx#L478 NumericFormat Component round value before formatting it with numericFormatter function