refactor: clean up `updateValueAndCaretPosition`

s-yadav / react-number-format

React component to format numbers in an input or as a text.

MIT License

3.9k stars 410 forks source link

refactor: clean up `updateValueAndCaretPosition` #813

Closed csantos1113 closed 9 months ago

csantos1113 commented 1 year ago

Describe the change

updateValueAndCaretPosition is used only once
its params setCaretPosition and caretPos were always set to something static
- setCaretPosition: true
- caretPos not passed, hence undefined

This PR removes these 2 params; and removes unnecessary checks

Note: not sure if these params were used for different purposes in the past, or if they are planned to used differently in the future, but they are not used as of right now, so I'm removing them.

s-yadav commented 9 months ago

Yes, this method was earlier used when the value is changing from props, but that logic is changed now. Your changes look great. Will merge. Thanks