search

s-yata / marisa-trie

MARISA: Matching Algorithm with Recursively Implemented StorAge
Other
506 stars 89 forks source link

Update Entry to use NULL to mean empty. #9

Closed ilovezfs closed 7 years ago

ilovezfs commented 8 years ago

Fixes the following make check test failure when using clang:

TestEntry(): 212: Assertion `entry.ptr() == NULL' failed.

This is essentially the same fix as was used to fix ReverseKey in s-yata/marisa-trie@cbab26f0.

ilovezfs commented 8 years ago

As a side note, I also found that setting O1 lets the "old" code work.

ilovezfs commented 8 years ago

Anyone had a chance to review this?

ilovezfs commented 7 years ago

@s-yata ping on this.

ilovezfs commented 7 years ago

Boneyarding the formula in Homebrew/core for now at least.