search

s0 / git-publish-subdir-action

GitHub Action to push a subdirectory as a branch to any git repo (e.g. for GitHub Pages)
https://github.com/marketplace/actions/push-git-subdirectory-as-branch
MIT License
210 stars 36 forks source link

Force push and reset target branch #11

Closed kikisix closed 4 years ago

kikisix commented 4 years ago

Hi!

I really like this action. I use it as part of a pipeline to deploy to Heroku.

I noticed that a lot of heavy artifacts accumulate in the deployment branch, and periodically cleaned it locally, then pushed it to the remote again.

I think that I am not the only one who is faced with such a problem, and I propose adding the parameter Force which will help automate such cleaning.

I am not very strong in Typescript, but I hope that the pull request is correct, and the code does not contain complaints.

Thank you! I'll be grateful if you will apply this PR or send recommendations, or implement similar logic in your favourite way.

s0 commented 4 years ago

Thanks so much for this, i think it's a great idea! I've opened a pull request here: #17 that includes your changes, resolves conflicts, and made some improvements + added unit tests :)

(had to open a new PR so that the GitHub Action checks ran)

Thanks so much for your contribution!

s0 commented 4 years ago

And sorry for the delay, it's been a crazy couple of months!

kikisix commented 4 years ago

@s0 Don't worry, i was quite busy too. Thank you so much! :)