s0 / git-publish-subdir-action

GitHub Action to push a subdirectory as a branch to any git repo (e.g. for GitHub Pages)
https://github.com/marketplace/actions/push-git-subdirectory-as-branch
MIT License
208 stars 36 forks source link

fix: remove trailing newline of commit message #58

Closed vaporoxx closed 2 years ago

vaporoxx commented 2 years ago

After having experimented with this action for a bit, I found {msg} ({sha}) to be the commit message format I liked the most. However, there seemed to be a trailing newline at the end of the message, converting this example commit message: image into this one instead: image

I've went through the isomorphic-git source, and found this function which adds a single trailing newline on purpose. I think that it should be removed here though because it ruins the commit message and you can just add it back in your custom commit message if you need it.

s0 commented 2 years ago

Thanks for the contribution @vaporox, i'll create a new release shortly