search

s00500 / ESPUI

A simple web user interface library for ESP32 and ESP8266
https://valencia.lbsfilm.at/midterm-presentation/
Other
923 stars 174 forks source link

New features (time & separator) not working #165

Closed jrutlen closed 2 years ago

jrutlen commented 2 years ago

Describe the bug New features don't seem to be working correctly. I have version 2.1.0 of the library and when I try to utilize the features added on January 8th, I get compilation errors. If I'm doing something wrong, please let me know; I think it's an issue with the code because I receive the same error regarding the separators when I try to compile the provide Complete Example code. Do I have the wrong version of something?

To Reproduce Steps to reproduce the behavior:

  1. Add the invisible time update function or a separator
  2. Try to Compile
  3. See error

Expected behavior Code compiles without errors.

Screenshots Library Version UpdateTime UpdateTime2 Separator

Desktop (please complete the following information):

Additional context Adding multiple controls to the same panel seems to be broken as well - I receive no errors compiling but the extra buttons or switches just don't show up on the selected panel.

If everything is working correctly and I'm doing something wrong, I apologize and please let me know.

thomastech commented 2 years ago

I have version 2.1.0 of the library and when I try to utilize the features added on January 8th, I get compilation errors.

The Time Feature was added in PR #152 on Jan-29-2022, which came after the Jan-09 2.1.0 release.

Adding multiple controls to the same panel seems to be broken as well.

I believe this change came too late for inclusion in the official 2.1.0 release.

Instead of using the official release I suggest downloading the latest files from the ESPUI repository. Actually, I suggest getting them from @iangray001's repository at https://github.com/iangray001/ESPUI since it has his latest PR in it.

The latest files should get you going.

jrutlen commented 2 years ago

Thank you Thomas, I'm still figuring out github and found the commits page after posting my question. Thank you for confirming my suspicions, I didn't realize commits weren't included until a new official version was created. I wrongly assumed that since the documentation had been updated the updates were included in 2.1.0.

I will download iangray001's files now!

I'll confirm those files work and then close this issue.

Thanks again!

thomastech commented 2 years ago

I wrongly assumed that since the documentation had been updated the updates were included in 2.1.0.

The README docs you see online reflect late breaking changes. However, the README's found in the official release's zip file will probably be more aligned to the state of the library when the release was packaged "for sale."

Ian has been very good at keeping the docs updated as he adds features. In contrast, some Github projects are a mess because the docs are treated like forgotten step-children.

I'll confirm those files work and then close this issue.

I expect you'll have a much better experience with the latest files.

jrutlen commented 2 years ago

Everything is working perfectly after downloading the latest version from iangray001's repository. For anyone else that finds this, make sure you have Arduino 1.8.19+ as that version of the library wouldn't compile on 1.8.15.

Thanks Again Thomas!

-Jon