search

s00500 / ESPUI

A simple web user interface library for ESP32 and ESP8266
https://valencia.lbsfilm.at/midterm-presentation/
Other
896 stars 166 forks source link

FIX: gets local time instead of utc0 time #273

Closed haennes closed 9 months ago

haennes commented 9 months ago

Will get the local time based on the timezone reported by the device instead of utc0 which should make a lot more sense for this paticular use case

iangray001 commented 9 months ago

This is a breaking change, so probably should be added as another time component instead of changing the behaviour of the existing one.

haennes commented 9 months ago

Yes indeed. I could write it to use the name LocalTime instead. Whats the best Name for it?

iangray001 commented 9 months ago

LocalTime is a good suggestion, thanks.

haennes commented 9 months ago

Should the LocalTime be updated when updateTime() is called or should another Function be added as well?

iangray001 commented 9 months ago

I would suggest both be updated from updateTime()

haennes commented 9 months ago

I have change on the local_time branch in my fork I will close this PR in favor of a new one pulling from the fork. This is to not clutter the git history of the repo. Also: I dont have the Hardware anymore to compile and test the changes. Could sb else please test this?