search

s0faking / plugin.video.orfon

ORF ON is an Kodi addon that provides access to the ORF ON Video Platform (Austrian Television).
GNU General Public License v2.0
19 stars 2 forks source link

replace CRLF (windows) with LF (unix) line breaks #7

Closed Rechi closed 1 month ago

s0faking commented 1 month ago

hey rechi. thanks for the changes. sorry i missed that one and already had quite some changes for the new timeshift livestream in place. mea culpa, i'm slow these days with the little one keeping me busy

s0faking commented 1 month ago

@Rechi one question tough about the addon. i've been thinking to merge the orfon code with the tvthek addon. do you know by chance if it would be a problem to change the name in the addon.xml when publishing it on the official repo. I think this might be for the best, but i couldn't find anything in the addon submission guidelines. if not can you point me to someone who can help me with that question maybe? the IRC channel is not active anymore, right?

Rechi commented 1 month ago

IMO I don't see a problem. The important thing is to have a higher version number, as the already submitted version. https://github.com/basrieter (and https://github.com/enen92) are the ones reviewing the addon submissions. The IRC channel is still active.

I would try to submit it and look at the reviewers opinion. With an n existing PR it is easier for me to contact the person, if the are any issues or questions.

s0faking commented 1 month ago

ok thanks for the hints. i will go for the PR