search

s0faking / plugin.video.orftvthek

ORF TVthek - This KODI plugin provides access to the Austrian "ORF TVthek"
GNU General Public License v2.0
42 stars 19 forks source link

serviceAPI: fix play all #43

Closed Rechi closed 7 years ago

Rechi commented 7 years ago

without this change Kodi will get completely get stuck when trying to open Play all

s0faking commented 7 years ago

add this to the isengard branch. i've already made the change in the jarvis branch

Rechi commented 7 years ago

Why have you stared to create different branches for different versions? If you continue submitting it to Gotham (as you have done before) it will be in all versions newer than Gotham automatically. http://kodi.wiki/view/Submitting_Add-ons#Allowed_submissions

s0faking commented 7 years ago

well as i'm not really testing the addon on gotham anymore i decided to move to jarvis. do you think it would be better to support an older kodi version than jarvis?

i have to submit the updates to the offical repo with git now, thats why i made a jarvis branch. last time i did this for the puls4 addon i had to make quite some changes so i kind of tried to fix everything before i make my first pull request.

Rechi commented 7 years ago

Don't know if you are aware of http://mirrors.kodi.tv/stats?downloadstats=2017&filter=plugin.video.orftvthek. There you can see how often the addon has been downloaded for a specific kodi/addon version.

I would prefer if you still support older versions. Just have done a quick test and it does work.

If you need some assistance for submitting it to the official repo, just tell me.

s0faking commented 7 years ago

Don't know if you are aware of http://mirrors.kodi.tv/stats?downloadstats=2017&filter=plugin.video.orftvthek. There you can see how often the addon has been downloaded for a specific kodi/addon version.

wow. i didnt know about a statistics site. thats good to know. well then i guess we stick to gotham.

If you need some assistance for submitting it to the official repo, just tell me.

thanks. appreciate it. i'll come back to you when i get the first feedback from the submission. they look really close now, went kinda easier with the mailinglist, but always good when people care if you ask me