s0md3v / sd-webui-roop

roop extension for StableDiffusion web-ui
GNU Affero General Public License v3.0
3.4k stars 884 forks source link

Clicking "Interrupt" doesn't stop roop from doing its thing... #131

Open BigZampano opened 1 year ago

BigZampano commented 1 year ago

When I click "Interrupt", the image generation stops, but then roop still starts processing the canceled image, which takes up to a minute on my slow M1 Mac...

Is there a way to interrupt roop...?

Thanks in advance...!

Aptronymist commented 1 year ago

When I click "Interrupt", the image generation stops, but then roop still starts processing the canceled image, which takes up to a minute on my slow M1 Mac...

Is there a way to interrupt roop...?

Thanks in advance...!

My understanding, likely imperfect, is that processes like these in SD can only be interrupted when they're not doing torch operations, there's no way to interrupt torch until it hands back control to the extension or application.

BigZampano commented 1 year ago

Interesting, thanks for the clarification...!

Well then let's hope that torch never attempts for world domination... because "there's no way to interrupt torch until it hands back control"...

But still, when I interrupt while the image is still processing, roop isn't involved at all, it starts after the image is finished, so it should be possible to keep it from running at all...?!?

Aptronymist commented 1 year ago

But still, when I interrupt while the image is still processing, roop isn't involved at all, it starts after the image is finished, so it should be possible to keep it from running at all...?!?

Presumably, yeah. Perhaps skip might work better?