search

s12v / awsbeats

AWS Kinesis plugin for Filebeat
Apache License 2.0
61 stars 26 forks source link

fix: Correct records sent to Kinesis Data Streams #13

Closed mumoshu closed 6 years ago

mumoshu commented 6 years ago

glide up wasnt necessarily but anyway I verified this to work with the latest version of aws-sdk-go

Fixes #11

Depends on #12. Plese see the last commit to review the change made in this PR.

codecov-io commented 6 years ago

Codecov Report

Merging #13 into master will increase coverage by 3%. The diff coverage is 53.84%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #13   +/-   ##
=======================================
+ Coverage   21.73%   24.74%   +3%     
=======================================
  Files           3        3           
  Lines          92       97    +5     
=======================================
+ Hits           20       24    +4     
- Misses         67       68    +1     
  Partials        5        5
Impacted Files Coverage Δ
streams/client.go 21.05% <53.84%> (+4.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26fbf25...350b099. Read the comment docs.

di1214 commented 6 years ago

@mumoshu can you add the fix to firehose as well?

mumoshu commented 6 years ago

@di1214 Sure! But it is really up to @s12v whether the fix is actually merged or not. He is the author of awsbeats. I don't have write permission to this repository 😉