s12v / awsbeats

AWS Kinesis plugin for Filebeat
Apache License 2.0
61 stars 26 forks source link

fix(streams): Handle nil record(s) returned by aws-sdk-go #28

Closed mumoshu closed 6 years ago

mumoshu commented 6 years ago

Ref #27

codecov-io commented 6 years ago

Codecov Report

Merging #28 into master will decrease coverage by 0.84%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   33.89%   33.05%   -0.85%     
==========================================
  Files           4        4              
  Lines         118      121       +3     
==========================================
  Hits           40       40              
- Misses         71       74       +3     
  Partials        7        7
Impacted Files Coverage Δ
streams/client.go 24.39% <0%> (-0.93%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1ac4f11...d3df0c8. Read the comment docs.

mumoshu commented 6 years ago

Closing this in favor of #31. I've consolidated this into #31 and added tests there.