s12v / awsbeats

AWS Kinesis plugin for Filebeat
Apache License 2.0
61 stars 26 forks source link

Properly format json for firehose #40

Closed Bashton-MattBuckland closed 6 years ago

Bashton-MattBuckland commented 6 years ago

This was already done for streams in a086eea4

mumoshu commented 6 years ago

@Bashton-MattBuckland Hey. Thank you so much for the PR!

The build seems to be failing due to missing trailing newlines in the expected values. Could you update these test go sources?

--- FAIL: TestMapEvent (0.00s)
    client_test.go:21: Unexpected data: boom
=== RUN   TestMapEvents
--- FAIL: TestMapEvents (0.00s)
    client_test.go:35: Unexpected data boom
raymondbutcher commented 6 years ago

This commit is included in #44 so this PR can be closed.