s12v / awsbeats

AWS Kinesis plugin for Filebeat
Apache License 2.0
61 stars 26 forks source link

Fix firehose issues #44

Closed raymondbutcher closed 6 years ago

raymondbutcher commented 6 years ago

These are similar fixes to what has been done in the streams plugin.

@mumoshu please see the commit d0db8d4 as it looks like the same problem from #41 but I think this is a slightly neater way of handling it.

We've been running this branch for 3 weeks now and it's gone from crashing very often to not crashing at all.

Closes #39

codecov-io commented 6 years ago

Codecov Report

Merging #44 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #44   +/-   ##
=======================================
  Coverage   64.44%   64.44%           
=======================================
  Files           4        4           
  Lines         135      135           
=======================================
  Hits           87       87           
  Misses         42       42           
  Partials        6        6

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0b86784...d0db8d4. Read the comment docs.