Open edify42 opened 5 years ago
Merging #60 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #60 +/- ##
=======================================
Coverage 64.96% 64.96%
=======================================
Files 4 4
Lines 137 137
=======================================
Hits 89 89
Misses 42 42
Partials 6 6
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update b214ad0...e57d169. Read the comment docs.
Wow! I've never realized that Docker Hub had the build env support! I'll review this asap. Thanks for your contribution 👍
WHAT
Be able to inject
--build-arg
variables from the environment.WHY
A colleague and myself noticed how the docker images were being pushed on docker hub for this repo from the README.md link. We wanted newer images that could be built directly from the master branch here.
Instead I'd like to propose a number of buildable docker images repositories (e.g./metricbeat and /filebeat) each pointing to the master branch of this repo.
Within the Docker hub build configuration section, you can declare the environment variables like so:
Variables such as
BEAT_DOCKER_IMAGE
andBEAT_NAME
would be defined on the environment. TheIMAGE_TAG
would need ideally be semver'd in some way...Relates to the builds of images from this issue