search

s1s0 / toped

Cross platform, open source IC layout editor
http://www.toped.org.uk/
GNU General Public License v2.0
15 stars 8 forks source link

List union implementation ... #154

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
... will crash on random basis. Underlying implementation is looping 
<vector>.insert without refreshing the iterator. Vector expansion will cause 
reallocation (eventually) and "Reallocations in vector containers invalidate 
all previously obtained iterators, references and pointers." The latter will 
invalidate the iterator after which the code behaviour will be unpredictable

Original issue reported on code.google.com by krustev....@gmail.com on 13 Nov 2012 at 2:51

GoogleCodeExporter commented 9 years ago 
Fixed in r2310. Avoid using inserts.
Code looks much better like this, it even could be faster.

Original comment by krustev....@gmail.com on 14 Nov 2012 at 11:27

GoogleCodeExporter commented 9 years ago

Original comment by krustev....@gmail.com on 14 Nov 2012 at 11:27