search

s1s0 / toped

Cross platform, open source IC layout editor
http://www.toped.org.uk/
GNU General Public License v2.0
15 stars 8 forks source link

locklayer/hidelayer functions are broken #49

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
hidelayer and locklayer functions lead to crash of Toped at run-time.
It fixed in Rev. 1502 but needs more testing

Original issue reported on code.google.com by gaitukevich.s@gmail.com on 11 May 2010 at 2:57

GoogleCodeExporter commented 9 years ago 
It looks like rev. 1502 solved the problem. No crashes, no leakages.

Original comment by gaitukevich.s@gmail.com on 12 May 2010 at 2:49

GoogleCodeExporter commented 9 years ago 
Some leakages cleaned-up in r1521

Original comment by krustev....@gmail.com on 24 May 2010 at 9:38

GoogleCodeExporter commented 9 years ago

Original comment by krustev....@gmail.com on 4 Jul 2010 at 1:40

GoogleCodeExporter commented 9 years ago 
The Issue reopened, because it appears that it's the same root trouble like 
Issue 62. The fix must be changed.

Original comment by krustev....@gmail.com on 4 Jul 2010 at 1:42

GoogleCodeExporter commented 9 years ago 
The r1502 and r1521 were reverse merged (i.e. canceled). The new fix revisions 
are described in Issue 62.
The trouble is that unselectFromList() method is deleting its input parameter 
and that was seen as the problem initially. It appears not that simple though. 
The parameter is actually a deep structure and even after that delete was 
removed, the unselectFromList() was still deleting the underlying structures.
For reasons of symmetry with selectFromList() method, the changes in the 
unselectFromList() were canceled and the bug is fixed in the calling methods 
sending a copy of the structure as an input parameter. The same approach is 
used all over the place for the symmetrical method and even for this method 
before the updates in r1521. Some auxilary functions added for copy and clean 
of the SelectList structure.

Original comment by krustev....@gmail.com on 4 Jul 2010 at 4:09

GoogleCodeExporter commented 9 years ago 
Issue 62 has been merged into this issue.

Original comment by krustev....@gmail.com on 4 Jul 2010 at 10:40

GoogleCodeExporter commented 9 years ago

Original comment by krustev....@gmail.com on 1 Apr 2012 at 12:19