s1s0 / toped

Cross platform, open source IC layout editor
http://www.toped.org.uk/
GNU General Public License v2.0
15 stars 8 forks source link

Wire with overflow #80

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
Wire width is stored internally using unsigned short. If an user tries to 
create a wire > 65536 DBUs Toped silently overflows and in result a wire is 
created with a width = W % 65536.
We need
1. To issue an error if an attempt is made to create a wire with a width bigger 
than the store type (whatever it is)
2. To reconsider eventually the storage type to a bigger one - say unsigned int.

Original issue reported on code.google.com by krustev....@gmail.com on 6 Sep 2010 at 10:56

GoogleCodeExporter commented 9 years ago

Original comment by krustev....@gmail.com on 22 Sep 2010 at 9:19

GoogleCodeExporter commented 9 years ago
The wire width restriction is now parameterized and the value currently is 
2^31. So it is now possible ( r1642) to enter wires bigger than 65535 DBUs. The 
validation classes are updated with the corresponding checks for the maximum 
wire width. Two things remain though:-
- TDT format must be updated because the width there is of type unsigned short. 
This is always a bad news, but it will be upward compatible.
- There is no check currently whether the wire frame is going outside the 
canvas range. In other words another overflow is possible and should be taken 
care of.

Original comment by krustev....@gmail.com on 1 Oct 2010 at 4:40

GoogleCodeExporter commented 9 years ago
TDT format upreved to 0.8 on r1643. The rest is transferred to Issue 74.

Original comment by krustev....@gmail.com on 10 Oct 2010 at 8:15

GoogleCodeExporter commented 9 years ago

Original comment by krustev....@gmail.com on 1 Apr 2012 at 12:21