Description

Inspection values were not localizing correctly for the Value, Minimum, and Maximum properties if the type was a string instead of a number. This is due to a check in localizeNumber that checks if the value is of type number, otherwise returning the original value.

else if (format === 'Number' && typeof value === 'number') {
    return localizeNumber(value, locales);
  }

My code localizes the number before it is passed to computeTextStyle, ensuring that it is correctly localized even if it is a string.

Fixes #143 Fixes thematerials-network/CoA-schemas#46

Before:

After:

As you can see in the screenshot, the values for Value, Minimum and Maximum are now correctly localized (they contain commas instead of dots).

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

s1seven / schema-tools

fix: add localization for Value, Minimum and Maximum in inspections for generatePdf #144

Description

Type of change

Checklist: