eamon0989 commented 2 years ago

Description

This PR adds support for EN10168 v0.3.0. The main change is allowing createInspection to accept arrays of inspection objects as well as inspection objects. Added fixtures for v0.3.0. Added test for v0.3.0 PDF creation (commented out until the schema is released). Fixed a bug where PDFs wouldn't render when a SupplementaryInformation object was no present on some inspection properties (Issue 156) Fixes a bug where an empty row was added to the PDF when supplementary information was not provided (Issue 158).

[x] Fixes #153
[x] Fixes #156
[x] Fixes #158

Type of change

[x] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[x] This change requires a documentation update (EN10168 documentation)

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes
[x] Any dependent changes have been merged and published in downstream modules

getlarge commented 2 years ago

@eamon0989 Just need to fix the tests for the PDF and HTML generators and good to merge.

As you might have noticed when running the tests in the CI runner, there is that warning :

Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
...

Could you maybe run that command to update the supported browsers list and push the changed files ?

eamon0989 commented 2 years ago

@eamon0989 Just need to fix the tests for the PDF and HTML generators and good to merge.

As you might have noticed when running the tests in the CI runner, there is that warning :
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
...
Could you maybe run that command to update the supported browsers list and push the changed files ?

Will do 👍🏼